Landing cta #933
Landing cta #933
Conversation
jannekoivistoinen
force-pushed
the
landing-cta
branch
from
cf7df05
to
03c9464
Compare
.env.development.local
Outdated
| @@ -0,0 +1,2 @@ | |||
| REACT_APP_USE_EXAMPLE_CUSTOM_ATTRIBUTES=true | |||
| REACT_APP_GOOGLE_MAPS_API_KEY=AIzaSyDZhsJGsRv0c9HykUHfnVAIVOb1tWtqrTg | |||
There was a problem hiding this comment.
This file is in wrong place.
You should write these variables to the file called .env
| @@ -104,7 +104,7 @@ | |||
| font-weight: var(--fontWeightBold); | |||
| font-size: 30px; | |||
| line-height: 36px; | |||
| letter-spacing: -0.5px; | |||
| letter-spacing: -1px; | |||
There was a problem hiding this comment.
This should be mentioned in the Changelog.
If one of our customer has changed the font (or is just happy with current letter-spacing), it might need some adjustment from their own code base.
- marketplaceH1FontStyles: changed letter spacing to be more tight.
src/marketplace.css
Outdated
| buttons elements should have zero padding */ | ||
| padding: 20px 0 0 0; | ||
| buttons elements should have zero padding */ | ||
| padding: 16px 0 0 0; |
There was a problem hiding this comment.
This is likely to break buttons and baselines on every page.
Let's not do it on marketplace.css level!
SectionHero.css is better less scary place to make this change.
src/marketplace.css
Outdated
| @@ -212,6 +212,7 @@ | |||
|
|
|||
| @media (--viewportMedium) { | |||
| min-height: 65px; | |||
| padding: 20px 0 0 0; | |||
There was a problem hiding this comment.
This change is related to the comment above
This is likely to break buttons and baselines on every page.
Let's not do it on marketplace.css level!
SectionHero.css is better less scary place to make this change."
| name="SearchPage" | ||
| to={{ | ||
| search: | ||
| 's?address=Finland&bounds=70.0922932%2C31.5870999%2C59.693623%2C20.456500199999937', |
There was a problem hiding this comment.
We should probably tell about this in Change log.
- SectionHero has now a search page link that should be customized to point to your marketplace primary area
jannekoivistoinen
force-pushed
the
landing-cta
branch
from
c6f9335
to
56216e6
Compare
No description provided.