Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default API URL #912

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Update default API URL #912

merged 2 commits into from
Sep 5, 2018

Conversation

lyyder
Copy link
Contributor

@lyyder lyyder commented Aug 24, 2018

A first measure to ensure new FTW users have the correct API URL configured when they start development work.

The next step would be to

  • Set the default URL to the SDK
  • Allow overriding the SDK default URL with an env variable
  • Remove the API env variable from documentation as it's only intended for Flex developers

@lyyder lyyder requested a review from Gnito August 25, 2018 05:04
@Gnito Gnito merged commit e45e066 into master Sep 5, 2018
@Gnito Gnito deleted the default-api-url branch September 5, 2018 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gnito Gnito Awaiting requested review from Gnito

Assignees
No one assigned
Labels
review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lyyder @Gnito