Availability improvements #901
Conversation
In case max bookable day count exceeds 90 days, fetch a second batch of time slots.
| dispatch(timeSlotsRequest(secondParams)).then(secondBatch => { | ||
| const combined = timeSlots.concat(secondBatch); | ||
| dispatch(fetchTimeSlotsSuccess(combined)); | ||
| }); |
There was a problem hiding this comment.
Should there be a return before the dispatch or a .catch on the promise to handle error in the request?
There was a problem hiding this comment.
The .catch is left out so that in case of an error the .catch of the outer promise handles it. This way there error action is fired in case either of the time slot requests fail. A succeed action is dispatched when both requests succeed.
There was a problem hiding this comment.
How would a return help with handling a failing request here?
There was a problem hiding this comment.
The failing promise never goes to the outer .catch without the return.
There was a problem hiding this comment.
Well so it seems. I was sure I had this tested. Well spotted 👍, I'll add the return.
lyyder
force-pushed
the
max-time-slots
branch
2 times, most recently
from
7b254de
to
0414d2a
Compare
|
Added the missing |
Return the nested promise so that errors from it will be caucht in the catch block of the outer promise.
Fixes two problems with availability: