Mapbox Map component #896
Mapbox Map component #896
Conversation
kpuputti
force-pushed
the
mapbox-map
branch
2 times, most recently
from
7ffe33d
to
63dbca9
Compare
| return markerOverlay(center); | ||
| }; | ||
|
|
||
| class StaticMapboxMap extends Component { |
There was a problem hiding this comment.
Could this be a functional component?
There was a problem hiding this comment.
Yes, I can change to a function. But always creating a class also has the upside of not having to indent the whole component (and generating lots of diff) when it required state of lifecycle methods.
src/components/Map/Map.js
Outdated
| @@ -3,7 +3,8 @@ import { bool, number, object, string } from 'prop-types'; | |||
| import classNames from 'classnames'; | |||
| import { propTypes } from '../../util/types'; | |||
| import config from '../../config'; | |||
| import { StaticMap, DynamicMap, isMapsLibLoaded } from './GoogleMap'; | |||
| // import { StaticMap, DynamicMap, isMapsLibLoaded } from './GoogleMap'; | |||
There was a problem hiding this comment.
Is this comment something we'd leave to the code as an example on how to change the map implementation. Or remove when the map migration is complete?
There was a problem hiding this comment.
Oops, the Mapbox one should be commented out and the Google one in use. I'll fix that.
I'd leave the Mapbox imports as comments so we can easily test those while doing the whole map provider migration. We can decide to drop them when putting it all together in the end.
| @@ -45,8 +45,10 @@ export class Map extends Component { | |||
| /> | |||
| ) : ( | |||
| <DynamicMap | |||
| containerElement={<div className={classes} onClick={this.onMapClicked} />} | |||
There was a problem hiding this comment.
Where has the onClick gone?
There was a problem hiding this comment.
It wasn't used at all, there wasn't even a onMapClicked method that it was calling. It was probably copy pasted from SearchMap that had such method.
This page implements a version of the
Mapcomponent (used inListingPage) using Mapbox.Screenshots
Static map with marker
Dynamic map with marker
Static map with custom marker
Dynamic map with custom marker
Static map with fuzzy location circle
Dynamic map with fuzzy location circle