Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reusable SearchMap #882

Merged
merged 5 commits into from
Aug 3, 2018
Merged

Reusable SearchMap #882

merged 5 commits into from
Aug 3, 2018

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented Aug 2, 2018

Improved version of ReusableMapContainer (the original version was buggy).

This is needed for:

  • Performance: no need to load dynamic map every time user enters the search page view on SPA.
  • Efficient Google Maps usage: less unnecessary calls to instantiate a dynamic map.
  • Reaction to a bug when removing Google Map instance

@Gnito Gnito requested a review from lyyder August 2, 2018 21:32
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 2, 2018 21:35 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 2, 2018 22:01 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 2, 2018 22:38 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 2, 2018 22:46 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 2, 2018 23:01 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 3, 2018 09:57 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 3, 2018 10:53 Inactive
@Gnito Gnito temporarily deployed to sharetribe-starter-app August 3, 2018 11:06 Inactive
lyyder
lyyder approved these changes Aug 3, 2018
View reviewed changes
Copy link
Contributor

@lyyder lyyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good for a workaround. Let's see if there's an impact in the map usage.

@Gnito Gnito merged commit 0fb56d4 into master Aug 3, 2018
@Gnito Gnito deleted the reusable-searchmap-vol2 branch August 3, 2018 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyyder lyyder lyyder approved these changes

Assignees
No one assigned
Labels
review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gnito @lyyder