Improve listingpage lazy loading #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyyder
requested changes
Jul 20, 2018
| @@ -106,8 +110,8 @@ export const lazyLoadWithDimensions = (Component, options) => { | |||
| window.addEventListener('orientationchange', this.handleWindowResize); | |||
|
|
|||
| this.defaultRenderTimeout = window.setTimeout(() => { | |||
| if (this.isElementInViewport()) { | |||
| this.handleWindowResize(); | |||
| if (this.isElementNearViewport(0)) { | |||
There was a problem hiding this comment.
isElementNearViewport doesn't seem to take a param.
| @@ -120,7 +124,9 @@ export const lazyLoadWithDimensions = (Component, options) => { | |||
| } | |||
|
|
|||
| handleWindowResize() { | |||
| this.setDimensions(); | |||
| if (this.isElementNearViewport(NEAR_VIEWPORT_MARGIN)) { | |||
There was a problem hiding this comment.
isElementNearViewport doesn't seem to take a param, but it uses NEAR_VIEWPORT_MARGIN internally.
Gnito
force-pushed
the
improve-listingpage-lazy-loading
branch
from
3a5fa17
to
ab81987
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.