Listingpage static map #869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
listingpage-static-map
branch
from
6c31d07
to
0f75296
Compare
lyyder
reviewed
Jul 19, 2018
src/components/Map/StaticMap.js
Outdated
|
|
||
| // Extract color from string. Given value should be either with '#' (e.g. #FFFFFF') or without it. | ||
| const formatColorFromString = color => { | ||
| if (typeof color !== 'string' && /^#[0-9A-F]{6}$/i.test(color)) { |
There was a problem hiding this comment.
What should the type be here if not string?
There was a problem hiding this comment.
Should it be typeof color === 'string'? Same thing also below.
lyyder
reviewed
Jul 19, 2018
| // The resize event is flooded when the browser is resized. We'll | ||
| // use a small timeout to throttle changing the viewport since it | ||
| // will trigger rerendering. | ||
| const THROTTLE_WAIT_MS = 200; |
Gnito
force-pushed
the
listingpage-static-map
branch
from
0f75296
to
fae2cc6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE 1: fuzzy location needs some extra work otherwise every page refresh is going to change the static map URL.
NOTE 2: map marker is moved to public/static/icons folder to be available for Google's static map API (works in production - localhost shows an error on top right corner of the generated map since the googleapis.com can't fetch the image from localhost.)