Fetch availability data #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Jul 18, 2018
|
|
||
| return Promise.all([ | ||
| dispatch(showListing(listingId)), | ||
| dispatch(fetchTimeSlots(timeSlotsParams)), |
There was a problem hiding this comment.
As discussed IRL, I think this call should be included when flagged somehow in config.js
Gnito
requested changes
Jul 18, 2018
There was a problem hiding this comment.
I think there's 2 things to be changed:
- When buyr ends up to CheckoutPage, speculate and initiate calls might still throw an error related to time-slot being reserved (if that happens within few moments between redirecting to the checkout page and pressing the book button). That error needs some special handling.
- Add some flag to config.js (some marketplaces need this, others don't)
lyyder
force-pushed
the
fetch-availability-data
branch
from
82e2ca7
to
8c2033c
Compare
|
Put time slots fetching behind a flag. I'll leave the error message handling along with a changelog entry to a future PR when the availability can be passed to the calendar components and this whole thing can be tied together. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds availability data fetching for listing page on page load.