Improve tx page state management #866
Conversation
| // In case a transaction reference is found from a previous | ||
| // data load -> clear the state. Otherwise keep the non-null | ||
| // values which may have been set from a previous page. | ||
| const initialValues = txRef ? {} : pickBy(state, v => !!v); |
There was a problem hiding this comment.
Arrays are a problem here.
!![] => true
v => (Array.isArray(v) && !!v.length) || !!v
There was a problem hiding this comment.
@Gnito I thought about that and reasoned that if the state has en empty array it can be passed as an initial value as in initialState the value of messages, which seems to be the only array, is [].
However, what you proposed would be more explicit. Also empty objects are truthy too and for example there's the transactionRef which is an object and should be overridden with the value from initialState in case it is somehow has been set to {}.
I'll add handling for empty arrays and objects.
There was a problem hiding this comment.
Also, passing [] to
(Array.isArray(v) && !!v.length) || !!v
resolves to true
Also override empty arrays and objects with values from initialState.
The state management in the
loadDatafunction inTransactionPage.duckhas been somewhat problematic and this PR aims to improve it.Now
loadDatachecks if atransactionRefis found from state. It is set when a tx fetch succeeds. If atransactionRefis found it means the state holds data from a previous page load and the state is cleared. If the ref can not be found it means that the page has not been loaded or that thesetInitialValueshas been invoked for example with an initial message sending error information fromCheckoutPage.