Change clearErrors action to resetState #865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyyder
force-pushed
the
tx-duck-clear-state
branch
from
add80b4
to
21068fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#863 changed the
TransactionPage.duck.jsso that theloadDatafunction did not clear the whole state anymore but instead just cleared any possible errors in the state. This fixed a bug where any errors caused from sending an initial message in the checkout page were not passed to the tx page. Unfortunately, this also introduced a new bug. As the reducer uses messages in the state to create paging for the messages, old messages we're left hanging in the state and unrelated messages started showing up in activity feeds.This PR removes the
clearErrorsaction and introduces an action calledresetStatewhich in addition to clearing the errors also clears messages from the state.Suggestions for a more accurate name for
resetStateare welcome.