Fix clearing tx initial message before the page change is made #861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The state initialization is performed when the component goes into submittin mode. However, after the form is submitted, the component unmounts and the state is destroyed.
|
Now the state is not cleared during submit. A question is that if some values, like |
Gnito
reviewed
Jul 9, 2018
There was a problem hiding this comment.
Props change at least when inProgress changes in CheckoutPage. That would mean that possible errors are not shown when spinner is rotating on the submit button.
To fix this, you could add extra check when to show errors.
this.state.error && !submitInProgress ? ...
lyyder
force-pushed
the
initial-message-blink
branch
from
ff7a489
to
7dd6db1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a UI bug on checkout page where the initial message input is cleared slightly before the page changes to the tx page.
Before:
After:
