Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear cardtoken before redirecting #1114

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Clear cardtoken before redirecting #1114

merged 3 commits into from
Jun 11, 2019

Conversation

OtterleyW
Copy link
Contributor

@OtterleyW OtterleyW commented Jun 11, 2019

stripeCardToken didn't update when the user tried to book the same listing for a second
time. This update will clear the old card token from Redux store when redirecting to
TransactionPage.

@@ -190,6 +190,7 @@ export class CheckoutPageComponent extends Component {
const orderDetailsPath = pathByRouteName('OrderDetailsPage', routes, {
id: orderId.uuid,
});
this.props.onClearStripePaymentToken();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd spread this out on line 150 among other props.

Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One small suggestion.

@OtterleyW OtterleyW merged commit bc94c96 into master Jun 11, 2019
@OtterleyW OtterleyW deleted the fix-updating-cardtoken branch June 11, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants