Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade SDK #1111

Merged
merged 3 commits into from
Jun 11, 2019
Merged

Upgrade SDK #1111

merged 3 commits into from
Jun 11, 2019

Conversation

rap1ds
Copy link
Member

@rap1ds rap1ds commented Jun 10, 2019 •
edited
Loading

Upgrades SDK to v1.4.1

The new SDK version upgrades dependencies with security issues.

@rap1ds rap1ds temporarily deployed to sharetribe-starter-app June 10, 2019 08:51 Inactive
@rap1ds rap1ds temporarily deployed to sharetribe-starter-app June 10, 2019 09:56 Inactive
@rap1ds rap1ds force-pushed the upgrade-sdk branch 2 times, most recently from 3352e28 to 7e6cbbd Compare June 10, 2019 10:58
@rap1ds rap1ds requested review from Gnito and OtterleyW June 10, 2019 10:58
OtterleyW
OtterleyW approved these changes Jun 10, 2019
View reviewed changes
Copy link
Contributor

@OtterleyW OtterleyW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted a typo in changelog but otherwise LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
rap1ds and others added 3 commits June 11, 2019 10:29
@rap1ds
Upgrade SDK to v1.4.1
4aeb38f 
This version upgrades dependencies with security issues.
@rap1ds
Update CHANGELOG
2b48dfe
@rap1ds @OtterleyW
Update CHANGELOG.md
76107dd 
Co-Authored-By: Jenni Laakso <[email protected]>
@rap1ds rap1ds merged commit b5e8bd3 into master Jun 11, 2019
@rap1ds rap1ds deleted the upgrade-sdk branch June 11, 2019 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OtterleyW OtterleyW OtterleyW approved these changes

@Gnito Gnito Awaiting requested review from Gnito

Assignees
No one assigned
Labels
review comments review ok
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rap1ds @OtterleyW