Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix too early rendering of Menu #1096

Merged
merged 2 commits into from
May 22, 2019
Merged

Conversation

Gnito
Copy link
Contributor

@Gnito Gnito commented May 22, 2019

Menu needs to wait for mounting to calculate dimensions properly. Mainly this has been an issue in dev mode in styleguide.

@Gnito Gnito force-pushed the fix-too-early-rendering-of-menu branch from 4f21c69 to 5c533e8 Compare May 22, 2019 10:00
@Gnito Gnito temporarily deployed to sharetribe-starter-app May 22, 2019 10:13 Inactive
@Gnito Gnito changed the title Fix too early rendering of menu Fix too early rendering of Menu May 22, 2019
@Gnito Gnito merged commit 200ca60 into master May 22, 2019
@Gnito Gnito deleted the fix-too-early-rendering-of-menu branch May 22, 2019 10:24
@Gnito Gnito mentioned this pull request May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant