Fix class name for Styleguide examples #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
fix-classname-for-examples
branch
from
c3b114b
to
68abf0e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: Styleguide-components with additional CSS has stopped working.
I.e. ComponentName.example.css
Assumption: one of the library updates has changed the way how CSS Modules class names are generated. In essence it has been created in a format:
[name]_[local]__[hash]. However, since our naming pattern for ComponentName.example.css has included 2 periods (.) - it has probably only taken the first part of the name into account.To avoid this issue, we renamed all the example-specific CSS files:
Button.example.css -> ButtonExample.css
etc.