Move creating payment token to stripe.duck.js #1086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
create-payment-to-stripe-duck
branch
from
9b39b29
to
c1f930a
Compare
OtterleyW
changed the title
Gnito
reviewed
May 9, 2019
src/ducks/stripe.duck.js
Outdated
| }) | ||
| .catch(e => { | ||
| dispatch(stripePaymentTokenCreateError(e)); | ||
| log.error(e, 'stripe-payment-form-submit-failed', { |
There was a problem hiding this comment.
Add handling for storable error
Gnito
reviewed
May 9, 2019
| @@ -464,6 +468,10 @@ export class CheckoutPageComponent extends Component { | |||
| paymentInfo={intl.formatMessage({ id: 'CheckoutPage.paymentInfo' })} | |||
| authorDisplayName={currentAuthor.attributes.profile.displayName} | |||
| showInitialMessageInput={showInitialMessageInput} | |||
| onCreateStripePaymentToken={this.props.onCreateStripePaymentToken} | |||
There was a problem hiding this comment.
You should just spread this onCreateStripePaymentToken out of props similarly as the other ones.
Gnito
reviewed
May 9, 2019
| @@ -306,6 +286,10 @@ StripePaymentForm.propTypes = { | |||
| paymentInfo: string.isRequired, | |||
| authorDisplayName: string.isRequired, | |||
| showInitialMessageInput: bool, | |||
| onCreateStripePaymentToken: func, | |||
There was a problem hiding this comment.
You should add .isRequired flag here or add default values in StripePaymentForm.defaultProps
Gnito
approved these changes
May 9, 2019
OtterleyW
force-pushed
the
create-payment-to-stripe-duck
branch
from
ad90856
to
b4949b1
Compare
OtterleyW
force-pushed
the
create-payment-to-stripe-duck
branch
from
b4949b1
to
3029d8d
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.