Fix stripe connected check #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current check for Stripe account setup is looking for non-existent `stripeAccount` property, causing a spurious modal asking to set up payment info even though it has already been configured. Changing to check the currect property on the `currentUser` object.
Gnito
force-pushed
the
fix-stripe-connected-check
branch
from
32aaed1
to
d642620
Compare
Gnito
force-pushed
the
fix-stripe-connected-check
branch
from
d642620
to
44958f8
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous change from
currentUser.attributes.stripeConnectedto separately includedstripeAccountcaused errors since updates to currentUser entity didn't includestripeAccount.Including it every time sounds quite error-prone, so we reversed that change.