Don't mutate args in updatedEntities #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
May 7, 2019
| @@ -52,7 +53,7 @@ export const updatedEntities = (oldEntities, apiResponse) => { | |||
| const entity = entities[type][id.uuid]; | |||
There was a problem hiding this comment.
Deep cloning might be too heavy, but spread, at least, this entity and its attributes (can be done on line 29).
OtterleyW
force-pushed
the
no-mutated-args-in-updated-entities
branch
from
c8c0dc3
to
dfb8c97
Compare
OtterleyW
force-pushed
the
no-mutated-args-in-updated-entities
branch
from
dfb8c97
to
ec76c3f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.