SearchPage: use sparse fields to improve query performance #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
force-pushed
the
search-page-uses-sparse-fields
branch
from
508ae1e
to
812ec46
Compare
Gnito
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: If you have changed
ListingCardcomponent, check if any data is missing onSearchPage. This deliberately drops some of the fields of Listing entity away from template.This improves SearchPage performance a bit by reducing the amount of fetched data. It also serves as an example of how to use sparse fields:
This change also improved
ListingPagea bit, since we were making assumptions of certain data to be unnecessarily required.There are 2 renamed files in
src/containers/ListingPage/:SectionFeatures.js->SectionFeaturesMaybe.jsSectionHost.js->SectionHostMaybe.js