Improve bundling order #1024
Merged
Improve bundling order #1024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means PrimaryButton, SecondaryButton and InlineTextButton. However, those can still be used as before.
They are changed to use rootClassName for consistency and protection against future bundling order changes.
They are changed to use rootClassName for consistency and protection against future bundling order changes.
Gnito
force-pushed
the
improve-bundling-order
branch
from
c677d4f
to
b1eb69f
Compare
This was referenced Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bundling order with index.js file mitigates problems that might arise when trying to import components
that have circular dependencies to other components.
Read more from article how-to-fix-nasty-circular-dependency-issues
For customizers:
Before you take update from upstream (FTW repository), you should check if you have created new components and figure out where they should be inside
src/components/index.jsfile.PrimaryButton, SecondaryButton, and InlineTextButton have been changed to use
rootClassNamewhen it is appropriate:https://www.sharetribe.com/docs/guides/how-to-customize-ftw-styles/#styling-responsibility-parent-component-and-its-children
You could just use
classNameprop too (as before), but import-order affects to the generated CSS bundle - so, it's not as safe as usingrootClassName.