Show deleted user #1022
Merged
Show deleted user #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtterleyW
force-pushed
the
show-deleted-user
branch
3 times, most recently
from
0906d25
to
53035a9
Compare
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
reviewed
Feb 8, 2019
Gnito
requested changes
Feb 8, 2019
OtterleyW
force-pushed
the
show-deleted-user
branch
from
53035a9
to
7e87430
Compare
OtterleyW
force-pushed
the
show-deleted-user
branch
from
1e32195
to
35893e0
Compare
Gnito
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new component
UserDisplayNameis added for showing user display name and also handling the cases where a user is banned or deleted. When the user name must be a string instead of a component (e.g. inAvatarand inListingPage) you can use a new functionuserDisplayNameAsString. Together these will replace the olduserDisplayNamefunction which is now deprecated. There is quite a lot of file changes caused by updating test files.This PR contains also small bug fixes:
usernow accepts also banned or deleted user