Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move more documentation to Flex Docs #1015

Merged
merged 10 commits into from
Jan 29, 2019

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Jan 28, 2019

  • customization checklist
  • styling
  • icons
  • translations
  • tos and privacy policy
  • static pages
  • ci
  • deploying to production
  • extend listing data
  • extended data (removed)
  • search filters
  • folder structure
  • improving performance
  • redux
  • routing
  • update changelog

@kpuputti kpuputti force-pushed the customization-checklist-and-related-docs branch 2 times, most recently from 37c5b58 to 961e892 Compare January 29, 2019 11:32
@kpuputti kpuputti force-pushed the customization-checklist-and-related-docs branch from ea062b4 to 8bceee2 Compare January 29, 2019 13:34
docs/README.md Outdated
├── routeConfiguration.js
├── store.js
├── translations
└── util
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small suggestion, this might be more understandable if directories would include a trailing slash util/.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just copied the content from the existing doc, but you are right. I can change it here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

docs/README.md Outdated

This file contains default email templates for various needs (e.g. _booking-request-accepted_, or
_verify-your-email_). You should customize all the different files (\*-html.html, \*-subject.txt,
and \*-text.txt).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is outdated stuff, I think.

This file contains default email templates for transaction-specific needs (e.g. _booking-request-accepted_). However, there are some built-in email templates that you can change from [Flex Console](http://flex-console.sharetribe.com/email-templates/email-changed).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the email-template paragraph - otherwise looks good.

@kpuputti kpuputti merged commit e568640 into master Jan 29, 2019
@kpuputti kpuputti deleted the customization-checklist-and-related-docs branch January 29, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants