Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #1012

Merged
merged 4 commits into from
Jan 25, 2019
Merged

Update docs #1012

merged 4 commits into from
Jan 25, 2019

Conversation

kpuputti
Copy link
Contributor

@kpuputti kpuputti commented Jan 25, 2019

Many documentation articles are now moved to the Flex Docs website. This PR replaces the Markdown file contents with a link to the corresponding documentation in Flex Docs. This is to ensure that bookmarks to specific docs won't break. Some additional links e.g. to the Getting started section in Flex Docs are also added.

- Link to Flex Docs
- Replace content with a link to Flex Docs if content is moved there
CHANGELOG.md Outdated
@@ -14,6 +14,7 @@ way to update this template, but currently, we follow a pattern:

## Upcoming version 2019-XX-XX

- [#1012] Some of the documentation moved to Flex Docs: https://www.sharetribe.com/docs/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in the same format as the other changelog updates

- [change] Some of the documentation moved to Flex Docs: https://www.sharetribe.com/docs/
[#1013]](https://github.com/sharetribe/flex-template-web/pull/1012)

Copy link
Contributor

@OtterleyW OtterleyW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason there is a lot of - signs changed to *. Did you run yarn install when you started because Prettier update while ago changed those?

Otherwise LGTM

@kpuputti kpuputti merged commit caa074c into master Jan 25, 2019
@kpuputti kpuputti deleted the update-docs branch January 25, 2019 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants