Enable limiting location autocomplete to a certain country #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gnito
reviewed
Jan 17, 2019
src/config.js
Outdated
| // Limit location autocomplete to a one or more countries | ||
| // using ISO 3166 alpha 2 country codes separated by commas. | ||
| // If you don't want to limit the autocomplete you can comment out this value. | ||
| limit: ['AU'], |
There was a problem hiding this comment.
Maybe changing the name to countryLimit
There was a problem hiding this comment.
And don't leave this countryLimit active!
Gnito
reviewed
Jan 17, 2019
src/util/googleMaps.js
Outdated
| * | ||
| * @return {Promise<{ search, predictions[] }>} - Promise of an object | ||
| * with the original search query and an array of | ||
| * `google.maps.places.AutocompletePrediction` objects | ||
| */ | ||
| export const getPlacePredictions = (search, sessionToken) => | ||
| export const getPlacePredictions = (search, sessionToken, restriction) => |
There was a problem hiding this comment.
It is probably better to rename this to searchConfigurations (or something like that) since there are more configurations that could be passed in than just componentRestrictions
Gnito
reviewed
Jan 17, 2019
| const limitCountriesMaybe = config.maps.search.limit | ||
| ? { country: config.maps.search.limit } | ||
| : {}; | ||
| const restriction = { componentRestrictions: { ...limitCountriesMaybe } }; |
There was a problem hiding this comment.
Let's not send a key componentRestrictions if there is no countryLimit set.
const limitCountriesMaybe = config.maps.search.limit
? {
componentRestrictions: {
country: config.maps.search.limit,
},
}
: {};Then limitCountriesMaybe could be spread directly to the call:
return getPlacePredictions(search, this.getSessionToken(), limitCountriesMaybe).then(results => {
OtterleyW
force-pushed
the
limit-location-autocomplete
branch
from
8ff13c8
to
8fab542
Compare
OtterleyW
force-pushed
the
limit-location-autocomplete
branch
from
8fab542
to
6ff26d4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limit location autocomplete by adding an optional country parameter to geocoding call in both Mapbox and Google Maps integrations. Variable used to enable this is
config.maps.search.limitand it can be found fromconfig.jsfile. The same variable works for Mapbox and Google Maps integrations.Also updated Mapbox SDK to version 0.5.0.