Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use env variable to enable or disable availability calendar #1000

Merged
merged 4 commits into from
Jan 17, 2019

Conversation

OtterleyW
Copy link
Contributor

@OtterleyW OtterleyW commented Jan 16, 2019

Environment variable REACT_APP_AVAILABILITY_ENABLED now determines whether the availability calendar is used or not.

In the config.js file variable fetchAvailableTimeSlots is now renamed to more general enableAvailability because it affects both fetching availability data and enabling the availability calendar.

@OtterleyW OtterleyW force-pushed the use-env-variable-to-enable-availability-calendar branch from a2e9332 to 7c3300f Compare January 16, 2019 11:29
@OtterleyW OtterleyW force-pushed the use-env-variable-to-enable-availability-calendar branch from 7c3300f to b46e60d Compare January 16, 2019 11:30
@OtterleyW OtterleyW requested a review from Gnito January 16, 2019 11:33
Copy link
Contributor

@Gnito Gnito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but add some note that fetchAvailableTimeSlots has been renamed (to the description of this PR and it wouldn't hurt to have it in the changelog too).

@OtterleyW OtterleyW force-pushed the use-env-variable-to-enable-availability-calendar branch from b46e60d to 1ef6d84 Compare January 17, 2019 07:36
@OtterleyW OtterleyW merged commit 999c12b into master Jan 17, 2019
@OtterleyW OtterleyW deleted the use-env-variable-to-enable-availability-calendar branch January 17, 2019 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants