Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile builder/spec v0.2 update #10

Closed
4 of 5 tasks
kpwebb opened this issue Mar 10, 2018 · 8 comments
Closed
4 of 5 tasks

tile builder/spec v0.2 update #10

kpwebb opened this issue Mar 10, 2018 · 8 comments

Comments

@kpwebb
Copy link
Member

kpwebb commented Mar 10, 2018

cc @migurski @DenisCarriere

Making a list of changes for the v0.2 re of the tile builder. Current changes include:

Curious if we should add hierarchical filtering of road network based on OSM classification -- or shift that to the client libraries (currently leaning toward implementing in the client).

@DenisCarriere
Copy link

👍 I'll update the Javascript library to reflect five decimals and 1m for distances

@kpwebb
Copy link
Member Author

kpwebb commented Mar 18, 2018

@DenisCarriere and @migurski the new v0.2 tiles are up at

https://tiles.sharedstreets.io/planet-180312/

Let me know once you' have a chance check and I'll switch the API end point to make these at the default, and cut a formal release for ss-builder!

Also, FYI, keeping old tiles and generating more historical versions from past OSM planet files to aid in OMS QA process.

migurski added a commit to sharedstreets/sharedstreets-python that referenced this issue Mar 19, 2018
@migurski
Copy link

Thanks @kpwebb, working on it!

By the way, we’re seeing CORS errors at https://platform.sharedstreets.io/37.81262/-122.26065/16.754/

@migurski
Copy link

Followup: we would need new versions of the .proto file and generated Python code, is that right?

@kpwebb
Copy link
Member Author

kpwebb commented Mar 20, 2018

If you want to take advantage of the new fields for street names, yes, but new data should be backwards compatible. Let me know if you see issues.

@kpwebb
Copy link
Member Author

kpwebb commented Mar 20, 2018

@migurski see ^^^^ Also not seeing CORS issues -- can you post what you're seeing? I did witness some odd errors fetch via CURL from CloudFront earlier today, but wasn't able to track down cause.

@migurski
Copy link

migurski commented Mar 21, 2018

I have a PR above for the new tile versions. The v0.2 ones look great, feel free to cut over whenever you want.

I also went back and checked for CORS errors and whatever we were seeing is not a problem anymore.

@kpwebb
Copy link
Member Author

kpwebb commented Apr 26, 2018

Just adding this as an FIY re CORS. We've been intermittently encountering CORS failures via CloudFront.

Here's why:

https://serverfault.com/questions/856904/chrome-s3-cloudfront-no-access-control-allow-origin-header-on-initial-xhr-req

@kpwebb kpwebb closed this as completed Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants