Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search for groups is broken since ldapjs 3.0.0 #56

Closed
pizzafroide opened this issue Jul 27, 2023 · 3 comments
Closed

Search for groups is broken since ldapjs 3.0.0 #56

pizzafroide opened this issue Jul 27, 2023 · 3 comments

Comments

@pizzafroide
Copy link

Since ldapjs 3.0.0, message objects no longer have a .object accessor. It is replaced by .pojo.

Message objects no longer have a .object accessor. This has been replaced with the .pojo accessor. It didn't make any sense to have a message object with an accessor that returns an object (it's confusing). The .pojo accessor states what will be returned: a plain JavaScript object. You may find that the actual message object now has fields you can directly use. See #841.

But ldap-authentication still uses the old accessor here and the groups property in the resulting object is therefore an array of undefined...

@mmende
Copy link
Contributor

mmende commented Sep 11, 2023

I made a PR to fix this issue: #57

@shaozi shaozi closed this as completed Sep 26, 2023
@MalfuncEddie
Copy link

not sure howe this works but the latest version on npm does not contain this fix?

https://www.npmjs.com/package/ldap-authentication/v/3.0.3?activeTab=code

@pizzafroide
Copy link
Author

#57 is merged but the fix won't be available on npm until the next release. Dunno when it's planned though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants