Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES6 support #40

Open
honzahajek opened this issue Nov 2, 2022 · 3 comments
Open

ES6 support #40

honzahajek opened this issue Nov 2, 2022 · 3 comments
Labels
v4 will implemented in v4

Comments

@honzahajek
Copy link

honzahajek commented Nov 2, 2022

const {authenticate} = require("ldap-authentication");
to
import {authenticate} from "ldap-authentication";

and another required packages

https://stackblitz.com/edit/vite-ldap?file=main.js&terminal=dev

@honzahajek honzahajek changed the title Change require to import (vite3/vue3 not support require) ES6 support Nov 2, 2022
@honzahajek honzahajek reopened this Nov 3, 2022
@shaozi
Copy link
Owner

shaozi commented Nov 11, 2022

does this change break scripts that are using require ?

@shaozi
Copy link
Owner

shaozi commented Nov 18, 2022

I incline to implement this since es6 in Node is mature and has large user base. The only concern I have is that existing cjs users will be forced to move their projects to es6.

If you have a backward compatible way of this transaction please share it here.

@shaozi
Copy link
Owner

shaozi commented Oct 8, 2024

This issue will be addressed in v4 since napi-rs has built-in solutions

@shaozi shaozi added the v4 will implemented in v4 label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v4 will implemented in v4
Projects
None yet
Development

No branches or pull requests

2 participants