Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node_modules dir part of package #4

Open
LaurensRietveld opened this issue Nov 29, 2024 · 1 comment
Open

node_modules dir part of package #4

LaurensRietveld opened this issue Nov 29, 2024 · 1 comment
Assignees
@shanewholloway

Comments

@LaurensRietveld
Copy link

The unittest/node_modules dir is part of the published npm package. This should be npm-ignored instead, and installation of node_modules directory should be delegated to npm or yarn
@LaurensRietveld LaurensRietveld mentioned this issue Nov 29, 2024
Closed
@shanewholloway
Copy link
Owner

shanewholloway commented Dec 8, 2024 •
edited
Loading

This should be fixed with [email protected]. Please let me know if further tweaks are needed.

@shanewholloway shanewholloway self-assigned this Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shanewholloway shanewholloway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore unittest dir when publishing LaurensRietveld/js-esm-seedrandom
2 participants
@shanewholloway @LaurensRietveld