Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Please add Typescript declarations #1

Open
mmjr-x opened this issue Feb 16, 2021 · 3 comments
Open

[Feature Request] Please add Typescript declarations #1

mmjr-x opened this issue Feb 16, 2021 · 3 comments

Comments

@mmjr-x
Copy link

mmjr-x commented Feb 16, 2021

First and foremost, thank you very much for taking the time to convert seedrandom to the ESM standard! :D

I was wondering if it would be possible for you to to add Typescript declarations for this project. There are currently 2 ways you could support this:

  1. This can either be done by adding types to the project itself (as is described in this PR for the original seedrandom package Typescript declaration davidbau/seedrandom#70)
  2. Or it could be done through a separate package released to de definitely typed package (the one for the original seedrandom package can be found here https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/seedrandom )

If you could take a look at this it would be much appreciated? :)

@mitar
Copy link

mitar commented Nov 14, 2022

Please please. :-)

@GadgetBlaster
Copy link

+1. This would make this package very useful.

@shanewholloway
Copy link
Owner

I don't use type definitions or TypeScript, so I'd have a hard time knowing if this is working well. I'd be willing to review and accept a pull request to add the type definitions directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants