From 792f14a53cb4ab264abaa0b445aef3490108b947 Mon Sep 17 00:00:00 2001 From: Shaleen Jain Date: Tue, 24 Apr 2018 14:06:04 +0530 Subject: [PATCH 1/3] fix crash on pre-lollipop --- .../java/com/shalzz/attendance/ui/splash/SplashActivity.java | 1 - app/src/main/res/drawable/launch_screen.xml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/java/com/shalzz/attendance/ui/splash/SplashActivity.java b/app/src/main/java/com/shalzz/attendance/ui/splash/SplashActivity.java index 674ab988..765455f8 100644 --- a/app/src/main/java/com/shalzz/attendance/ui/splash/SplashActivity.java +++ b/app/src/main/java/com/shalzz/attendance/ui/splash/SplashActivity.java @@ -27,7 +27,6 @@ import com.bugsnag.android.Bugsnag; import com.bugsnag.android.Severity; import com.google.firebase.analytics.FirebaseAnalytics; -import com.shalzz.attendance.BuildConfig; import com.shalzz.attendance.R; import com.shalzz.attendance.data.local.PreferencesHelper; import com.shalzz.attendance.ui.base.BaseActivity; diff --git a/app/src/main/res/drawable/launch_screen.xml b/app/src/main/res/drawable/launch_screen.xml index 392cb87e..be419a08 100644 --- a/app/src/main/res/drawable/launch_screen.xml +++ b/app/src/main/res/drawable/launch_screen.xml @@ -31,7 +31,7 @@ android:height="64dp" android:gravity="top"> - + From cd57e54433bb4bbd8edf6ed3efbd2848ad23abcc Mon Sep 17 00:00:00 2001 From: Shaleen Jain Date: Tue, 24 Apr 2018 14:07:39 +0530 Subject: [PATCH 2/3] use simple class name for analytics --- .../shalzz/attendance/ui/attendance/AttendanceListFragment.java | 2 +- .../shalzz/attendance/ui/settings/AboutSettingsFragment.java | 2 +- .../com/shalzz/attendance/ui/settings/SettingsFragment.java | 2 +- .../shalzz/attendance/ui/timetable/TimeTablePagerFragment.java | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/app/src/main/java/com/shalzz/attendance/ui/attendance/AttendanceListFragment.java b/app/src/main/java/com/shalzz/attendance/ui/attendance/AttendanceListFragment.java index d0b252c6..44a44ccf 100644 --- a/app/src/main/java/com/shalzz/attendance/ui/attendance/AttendanceListFragment.java +++ b/app/src/main/java/com/shalzz/attendance/ui/attendance/AttendanceListFragment.java @@ -194,7 +194,7 @@ public View onCreateView( @NonNull LayoutInflater inflater, ViewGroup container, @Override public void onStart() { super.onStart(); - mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getName()); + mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getSimpleName()); } @Override diff --git a/app/src/main/java/com/shalzz/attendance/ui/settings/AboutSettingsFragment.java b/app/src/main/java/com/shalzz/attendance/ui/settings/AboutSettingsFragment.java index 80b4a4dd..0b5e1da3 100644 --- a/app/src/main/java/com/shalzz/attendance/ui/settings/AboutSettingsFragment.java +++ b/app/src/main/java/com/shalzz/attendance/ui/settings/AboutSettingsFragment.java @@ -61,7 +61,7 @@ public void onCreatePreferences(Bundle bundle, String s) { @Override public void onStart() { super.onStart(); - mTracker.setCurrentScreen(mainActivity, getClass().getSimpleName(), getClass().getName()); + mTracker.setCurrentScreen(mainActivity, getClass().getSimpleName(), getClass().getSimpleName()); } @Override diff --git a/app/src/main/java/com/shalzz/attendance/ui/settings/SettingsFragment.java b/app/src/main/java/com/shalzz/attendance/ui/settings/SettingsFragment.java index 0caa32f7..763471c5 100644 --- a/app/src/main/java/com/shalzz/attendance/ui/settings/SettingsFragment.java +++ b/app/src/main/java/com/shalzz/attendance/ui/settings/SettingsFragment.java @@ -122,7 +122,7 @@ public void onCreatePreferences(Bundle bundle, String s) { @Override public void onStart() { super.onStart(); - mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getName()); + mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getSimpleName()); } public void onSharedPreferenceChanged(SharedPreferences sharedPreferences, String key) { diff --git a/app/src/main/java/com/shalzz/attendance/ui/timetable/TimeTablePagerFragment.java b/app/src/main/java/com/shalzz/attendance/ui/timetable/TimeTablePagerFragment.java index 10084639..8bb2a072 100644 --- a/app/src/main/java/com/shalzz/attendance/ui/timetable/TimeTablePagerFragment.java +++ b/app/src/main/java/com/shalzz/attendance/ui/timetable/TimeTablePagerFragment.java @@ -81,7 +81,7 @@ public class TimeTablePagerFragment extends Fragment implements TimeTableMvpView @Override public void onStart() { super.onStart(); - mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getName()); + mTracker.setCurrentScreen(mActivity, getClass().getSimpleName(), getClass().getSimpleName()); } @Override From ede53252fb0b3c15dfba06acc6d8de9ed8f0cd86 Mon Sep 17 00:00:00 2001 From: Shaleen Jain Date: Tue, 24 Apr 2018 14:10:07 +0530 Subject: [PATCH 3/3] update whatsnew --- app/src/main/play/en-US/whatsnew | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/src/main/play/en-US/whatsnew b/app/src/main/play/en-US/whatsnew index 6804a3a4..e28bf118 100644 --- a/app/src/main/play/en-US/whatsnew +++ b/app/src/main/play/en-US/whatsnew @@ -1,2 +1 @@ -• Introduced Pro Mode which unlocks additional features. -• Bug fixes and improvements +• fix crash on pre-lollipop devices