fix: account for ListHeaderComponent length when calculating offset in VirtualizedList - fixes facebook#16612

shakyShane · shakyShane · commit 4d1979ade7e0 · 2017-10-31T11:17:27.000Z
diff --git a/Libraries/Lists/VirtualizedList.js b/Libraries/Lists/VirtualizedList.js
@@ -1004,7 +1004,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {
   }
 
   _selectOffset(metrics: {x: number, y: number}): number {
-    return !this.props.horizontal ? metrics.y : metrics.x;
+    return (
+      (!this.props.horizontal ? metrics.y : metrics.x) - this._headerLength
+    );
   }
 
   _maybeCallOnEndReached() {

Original file line number	Diff line number	Diff line change
`@@ -1004,7 +1004,9 @@ class VirtualizedList extends React.PureComponent<Props, State> {`
`1004`	`1004`	`}`
`1005`	`1005`
`1006`	`1006`	`_selectOffset(metrics: {x: number, y: number}): number {`
`1007`		`- return !this.props.horizontal ? metrics.y : metrics.x;`
	`1007`	`+ return (`
	`1008`	`+ (!this.props.horizontal ? metrics.y : metrics.x) - this._headerLength`
	`1009`	`+ );`
`1008`	`1010`	`}`
`1009`	`1011`
`1010`	`1012`	`_maybeCallOnEndReached() {`