Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working at all #47

Open
Simon1511 opened this issue Aug 5, 2021 · 12 comments
Open

Not working at all #47

Simon1511 opened this issue Aug 5, 2021 · 12 comments

Comments

@Simon1511
Copy link

Hi,
so far I've tried all possibilities to install magisk with the steps given here.
However, none of them work. It doesnt matter if I run patch.sh normally, with canary or with anything else.
It does seem to patch the ramdisk.img correctly since the patched one is 1.8MB instead of 1.5MB (original ramdisk.img).
I then replace the original ramdisk.img with the patched one (and yes, I replaced the correct one), but yet magisk manager shows that its not installed.

Im running the Pixel 3a XL one with android 11.

Any suggestions?

@Discover999
Copy link

Discover999 commented Aug 8, 2021

same . I use magisk 21.4 and then I found it work!

@Simon1511
Copy link
Author

same . I use magisk 21.4 and then I found it work!

So it works with 21.4, but not with the latest?

@Discover999
Copy link

same . I use magisk 21.4 and then I found it work!

So it works with 21.4, but not with the latest?

https://github.com/topjohnwu/Magisk/releases/download/v21.4/Magisk-v21.4.zip
Use this one,I think it will work!

@Cloufish
Copy link

Cloufish commented Aug 15, 2021

https://github.com/topjohnwu/Magisk/releases/download/v21.4/Magisk-v21.4.zip
Use this one,I think it will work!

For me, it doesn't work either :/
image

$ patch.sh

ramdisk.img: 1 file pushed, 0 skipped. 612.3 MB/s (1821425 bytes in 0.003s)
magisk.zip: 1 file pushed, 0 skipped. 452.1 MB/s (6173806 bytes in 0.013s)
busybox: 1 file pushed, 0 skipped. 165.7 MB/s (2074240 bytes in 0.012s)
process.sh: 1 file pushed, 0 skipped. 134.4 MB/s (11525 bytes in 0.000s)
[*] Checking Android version
[*] Unzipping Magisk ..
[-] API level greater then 30
[*] Check if we need to repack ramdisk before patching ..
[*] Checking ramdisk status ..
[-] Magisk patched boot image detected
[*] Patching ramdisk ..

Loading cpio: [/data/local/tmp/ramdisk.img]
Add entry [init] (0750)
Patch with flag KEEPVERITY=[false] KEEPFORCEENCRYPT=[true]
Found fstab file [first_stage_ramdisk/fstab.ranchu]
Remove pattern [,avb=vbmeta]
Found fstab file [fstab.ranchu]
Remove pattern [,avb=vbmeta]
Loading cpio: [/data/local/tmp/ramdisk.img.orig]
Backup mismatch entry: [first_stage_ramdisk/fstab.ranchu] -> [.backup/first_stage_ramdisk/fstab.ranchu]
Backup mismatch entry: [fstab.ranchu] -> [.backup/fstab.ranchu]
Backup mismatch entry: [init] -> [.backup/init]
Create directory [.backup] (0000)
Add entry [.backup/.magisk] (0000)
Dump cpio: [/data/local/tmp/ramdisk.img]
[*] Done patching, compressing ramdisk ..
[*] Installing MagiskManager ..
su: invalid uid/gid '-c'
[*] Installing su binaries ..
mkdir: '/data/user_de/0/com.topjohnwu.magisk/install/': File exists
total 3452
-rwxr-xr-x 1 root root    3507 2021-08-15 11:29 addon.d.sh
-rwxr-xr-x 1 root root    4703 2021-08-15 11:29 boot_patch.sh
-rwxr-xr-x 1 root root 2074240 2021-08-15 11:29 busybox
drwxr-xr-x 2 root root    4096 2021-08-15 11:20 chromeos
-rwxr-xr-x 1 root root  313144 2021-08-15 11:29 magisk
-rwxr-xr-x 1 root root  456428 2021-08-15 11:29 magiskboot
-rwxr-xr-x 1 root root  609452 2021-08-15 11:29 magiskinit
-rwxr-xr-x 1 root root   22136 2021-08-15 11:29 util_functions.sh
[*] Clean up
/data/local/tmp/ramdisk.img: 1 file pulle...ped. 153.4 MB/s (1821425 bytes in 0.011s

I see this error line:

su: invalid uid/gid '-c'

And yeah I get that -c flag is used to execute a particular command as a sudo user, but then... process.sh prepares busybox, so there shouldn't be any differences when executing su -c on many different AVD Emulators

@Discover999
Copy link

image
image

I tried it again and it works :)
not error line with su: invalid uid/gid '-c'
no idea where you went wrong :(

@Cloufish
Copy link

Cloufish commented Aug 15, 2021

Okay.. Re-tried, and now it worked! 👍 ;-;.
I think that's because the second attempt of patching ramdisk was on already patched ramdisk.iso (with newer version)
Thank you @Discover999 :)

@Spider84
Copy link

Not work with Android Pie emulator :(
ramdisk is Patched, and Magist App is installed, but Application not detected Magisk :(

ramdisk.img: 1 file pushed, 0 skipped. 4275.1 MB/s (1748302 bytes in 0.000s)
magisk.zip: 1 file pushed, 0 skipped. 669.8 MB/s (6173806 bytes in 0.009s)
busybox: 1 file pushed, 0 skipped. 4285.5 MB/s (2074240 bytes in 0.000s)
process.sh: 1 file pushed, 0 skipped. 211.8 MB/s (11525 bytes in 0.000s)
[*] Checking Android version
[*] Unzipping Magisk ..
[*] Checking ramdisk status ..
[-] Stock boot image detected
[*] Patching ramdisk ..
 
Loading cpio: [/data/local/tmp/ramdisk.img]
Add entry [init] (0750)
Patch with flag KEEPVERITY=[false] KEEPFORCEENCRYPT=[true]
Loading cpio: [/data/local/tmp/ramdisk.img.orig]
Backup mismatch entry: [init] -> [.backup/init]
Create directory [.backup] (0000)
Add entry [.backup/.magisk] (0000)
Dump cpio: [/data/local/tmp/ramdisk.img]
[*] Done patching, compressing ramdisk ..
[*] Installing MagiskManager ..
[*] Installing su binaries ..
total 3420
-rwxr-xr-x 1 root root    3507 2021-08-26 17:31 addon.d.sh
-rwxr-xr-x 1 root root    4703 2021-08-26 17:31 boot_patch.sh
-rwxr-xr-x 1 root root 2074240 2021-08-26 17:31 busybox
drwxr-xr-x 2 root root    4096 2021-08-26 17:31 chromeos
-rwxr-xr-x 1 root root  313144 2021-08-26 17:31 magisk
-rwxr-xr-x 1 root root  456428 2021-08-26 17:31 magiskboot
-rwxr-xr-x 1 root root  609452 2021-08-26 17:31 magiskinit
-rwxr-xr-x 1 root root   22136 2021-08-26 17:31 util_functions.sh
[*] Clean up
/data/local/tmp/ramdisk.img: 1 file pulled, 0 skipped. 491.1 MB/s (2096326 bytes in 0.004s)

@Niktakolesn
Copy link

When I run the patch.bat command, I get an error

"adb" is not an internal or external
command, executable program, or batch file.

What should I do?

When I run the patch.sh command, it says

Adb not found

The .bat is referring to Adb, but what do I do with it to activate it?

@Cloufish
Copy link

When I run the patch.bat command, I get an error

"adb" is not an internal or external
command, executable program, or batch file.

What should I do?

When I run the patch.sh command, it says

Adb not found

The .bat is referring to Adb, but what do I do with it to activate it?

I assume you don't have $PATH Environment Variable set, to point to your adb executable @Niktakolesn

What is $PATH Environment Variable? - It's a system variable that keeps track of the binaries, executables, commands location.
When you execute adb, your system searches for an executable file, and it looks at the $PATH Variable, because directories listed there are meant to have commands that you can execute anywhere in the File System

See this blog-post -> https://www.addictivetips.com/windows-tips/system-wide-access-to-fastboot-and-adb-tools/
There's a chapter on setting Environment Variable with Android Platform Tools directory.
If the adb is not there, and you need to find adb location by yourself and add this directory to $PATH

@freerider7777
Copy link

freerider7777 commented Oct 21, 2021

I've installed version 23 On Pixel 3 API 30 (Android 11 with google services) emulator. I had some problems (wget could not download... some "segmentation faults" etc, but at some point it worked, maybe copying the correct clear ramdisk.img helped).

image

@freerider7777
Copy link

freerider7777 commented Oct 21, 2021

@89z I tried on Android 10 - it didn't work, then I tried with fresh Android 11 AVD - and it worked after some retries.
It's an emulator, I signed in to google account and they're sending me some spam (I've updated the picture) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants
@Spider84 @freerider7777 @Discover999 @Cloufish @Simon1511 @Niktakolesn and others