Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update railsContext documentation and fix generator #886

Merged
merged 3 commits into from
Jul 5, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Jul 2, 2017

This change is Reviewable

justin808 added 2 commits July 2, 2017 14:45
railsContext is not passed in as a second parameter when using an ES6
function for components.

Thus, removing from the generator.
@justin808 justin808 requested review from Judahmeek and robwise July 2, 2017 21:53
@justin808
Copy link
Member Author

This addresses #879.

@justin808 justin808 merged commit 8b7ac3a into master Jul 5, 2017
@justin808
Copy link
Member Author

@MiguelSavignano and @ceres629, I still welcome your feedback here.

@justin808 justin808 deleted the readme-updates branch July 5, 2017 04:21
@ceres629
Copy link

ceres629 commented Jul 5, 2017

Yes this is great, definitely much more useful, and while I did figure it out in the end, it would have saved me many hours of confusion and trial and error! Hopefully it does the same for new users.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants