Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecesary values from paths.yml #834

Merged
merged 1 commit into from
May 8, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# Used by webpacker_lite to configure the helpers and by webpack from the
# client/webpack.config.js file, in variable `paths`.
default: &default
output: public
assets: webpack
manifest: manifest.json
node_modules: client/node_modules
source: client/app

development:
<<: *default
Expand Down
10 changes: 5 additions & 5 deletions spec/dummy/client/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -68,13 +68,13 @@
"scripts": {
"lint": "eslint --ext .js,.jsx .",
"test": "yarn run build:test && rspec",
"build:test": "NODE_ENV=test yarn run build:client && NODE_ENV=test yarn run build:server",
"build:production:client": "NODE_ENV=production webpack --config webpack.client.rails.build.config.js",
"build:production:server": "NODE_ENV=production webpack --config webpack.server.rails.build.config.js",
"build:client": "webpack --config webpack.client.rails.build.config.js",
"build:test": "yarn run build:test:client && yarn run build:test:server",
"build:test:client": "NODE_ENV=test webpack --config webpack.client.rails.build.config.js",
"build:test:server": "NODE_ENV=test webpack --config webpack.server.rails.build.config.js",
"build:dev:client": "NODE_ENV=development webpack -w --config webpack.client.rails.build.config.js",
"build:dev:server": "NODE_ENV=development webpack -w --config webpack.server.rails.build.config.js",
"build:server": "webpack --config webpack.server.rails.build.config.js",
"build:production:client": "NODE_ENV=production webpack --config webpack.client.rails.build.config.js",
"build:production:server": "NODE_ENV=production webpack --config webpack.server.rails.build.config.js",
"hot-assets": "NODE_ENV=development babel-node server-rails-hot.js",
"install-react-on-rails": "rm -rf node_modules/react-on-rails && npm i 'file:../../..'"
},
Expand Down
5 changes: 2 additions & 3 deletions spec/dummy/config/webpack/paths.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
# Used by webpacker_lite to configure the helpers and by webpack from the
# client/webpack.client.base.config.js and other sibling config files, using variable `paths`.
default: &default
config: client/webpack
output: public
assets: webpack
manifest: manifest.json
source: client/app

development:
<<: *default
Expand Down