diff --git a/CHANGELOG.md b/CHANGELOG.md index 29597da51..5ec73db92 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,9 @@ Contributors: please follow the recommendations outlined at [keepachangelog.com] ## [Unreleased] +### Changed +- Update version_checker.rb to `logger.error` rather than `logger.warn` for gem/npm version mismatch. [#788](https://github.com/shakacode/react_on_rails/issues/788) by [justin808](https://github.com/justin808). + ### Fixed - Clear hydrated stores with each server rendered block. [#785](https://github.com/shakacode/react_on_rails/pull/785) by [udovenko](https://github.com/udovenko) diff --git a/lib/react_on_rails/version_checker.rb b/lib/react_on_rails/version_checker.rb index 75790530b..0c124e6a2 100644 --- a/lib/react_on_rails/version_checker.rb +++ b/lib/react_on_rails/version_checker.rb @@ -31,7 +31,7 @@ def log_differing_versions_warning " node package: #{node_package_version.raw}\n" \ "Ensure the installed MAJOR version of the gem is the same as the MAJOR version of \n"\ "your installed node package." - logger.warn(msg) + logger.error(msg) end def gem_version diff --git a/spec/react_on_rails/version_checker_spec.rb b/spec/react_on_rails/version_checker_spec.rb index fc1462c4b..7cda2b681 100644 --- a/spec/react_on_rails/version_checker_spec.rb +++ b/spec/react_on_rails/version_checker_spec.rb @@ -4,7 +4,7 @@ class FakeLogger attr_accessor :message - def warn(message) + def error(message) self.message = message end end