Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update version_checker.rb #788

Merged
merged 3 commits into from
Apr 2, 2017
Merged

Update version_checker.rb #788

merged 3 commits into from
Apr 2, 2017

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Apr 1, 2017 •
edited
Loading

Per #782 feedback that it's too easy to have the npm and gem out of sync.

This change is Reviewable

@coveralls
Copy link

coveralls commented Apr 1, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 97.922% when pulling e2c818c on justin808-change-logger-error-incorrect-npm-rubygems-combo into 5954e36 on master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.922% when pulling dbe5dcf on justin808-change-logger-error-incorrect-npm-rubygems-combo into 5954e36 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.922% when pulling dbe5dcf on justin808-change-logger-error-incorrect-npm-rubygems-combo into 5954e36 on master.

@justin808 justin808 merged commit f40f0d7 into master Apr 2, 2017
@justin808 justin808 deleted the justin808-change-logger-error-incorrect-npm-rubygems-combo branch June 4, 2017 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justin808 @coveralls