-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes turbolinks loading issue #221
Conversation
Code was checking that turbolinks was installed when it was not yet because some setups load turbolinks after the bundles. The changes to the code will check if turbolinks is installed after the page loaded event fires. Code was also added to allow easy debugging of Turbolinks, which should be useful when v5 of Turbolinks is released shortly. Details of how to configure Turbolinks with troubleshooting were added to docs/additional_reading/turbolinks.md. Also: * Changed generation of the examples apps to /tmp/examples. This allows one to configure editors to ignore /tmp. Ignoring /examples is problematic as one deletes the /examples directory frequently.
@alexfedoseev Can you please review ASAP Review status: 0 of 17 files reviewed at latest revision, all discussions resolved. Comments from the review on Reviewable.io |
@justin808 Looks good! One small comment. Review status: 0 of 22 files reviewed at latest revision, 1 unresolved discussion, some commit checks broke. spec/dummy/client/app/components/HelloWorld.jsx, line 22 [r1] (raw file): setDomRef(domNode) {
this.myDomRef = domNode;
}
handleChange() {
const myDomNode = this.myDomRef;
// ...
}
render() {
return (
<div
ref={this.setDomRef}
onChange={this.handleChange}
/>
);
} Comments from the review on Reviewable.io |
Reviewed 22 of 22 files at r1. Comments from the review on Reviewable.io |
Review status: 22 of 24 files reviewed at latest revision, 1 unresolved discussion. spec/dummy/client/app/components/HelloWorld.jsx, line 22 [r1] (raw file): Comments from the review on Reviewable.io |
Review status: 22 of 24 files reviewed at latest revision, 1 unresolved discussion. spec/dummy/client/app/components/HelloWorld.jsx, line 22 [r1] (raw file): Comments from the review on Reviewable.io |
Reviewed 2 of 2 files at r2. Comments from the review on Reviewable.io |
Review status: all files reviewed at latest revision, 1 unresolved discussion. spec/dummy/client/app/components/HelloWorld.jsx, line 22 [r1] (raw file): Comments from the review on Reviewable.io |
3566a4f
to
8b5c154
Compare
Reviewed 4 of 4 files at r3. Comments from the review on Reviewable.io |
with conversion to better dom ref syntax
Fixes turbolinks loading issue
Woo hoo! releasing later today!!! |
Code was checking that turbolinks was installed when it was not yet
because some setups load turbolinks after the bundles. The changes to
the code will check if turbolinks is installed after the page loaded
event fires.
Code was also added to allow easy debugging of Turbolinks, which should
be useful when v5 of Turbolinks is released shortly.
Details of how to configure Turbolinks with troubleshooting were added
to docs/additional_reading/turbolinks.md.
Also:
one to configure editors to ignore /tmp. Ignoring /examples is
problematic as one deletes the /examples directory frequently.