Tang rufus add skip display none

[aaronvb]

Merged PR #174 and added tests.

[justin808]

Need a test to verify that it's there in the normal case.

[aaronvb]

I believe the test above it should cover the normal case as it defaults to display: none, I didn't want to repeat the same line but I can add a test for default.

https://github.com/shakacode/react_on_rails/blob/TangRufus-add-skip-display-none/spec/dummy/spec/helpers/react_on_rails_helper_spec.rb#L50

[justin808]

@aaronvb I didn't see the test the specifies the basic case that the display: none is included if the config value is false. Can you point me to it?

---

Reviewed 4 of 4 files at r1, 3 of 3 files at r2.
Review status: all files reviewed at latest revision, all discussions resolved.

---

Comments from the review on Reviewable.io

[justin808]

Review status: all files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.

---

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file):
we test if the option is true

we need a test if the option is false

---

Comments from the review on Reviewable.io

[aaronvb]

@justin808 Adding it now, will push in a few!

[aaronvb]

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file):
Updated tests to include if option is false.

---

Comments from the review on Reviewable.io

[justin808]

---

Reviewed 1 of 1 files at r3.
Review status: all files reviewed at latest revision, 1 unresolved discussion.

---

spec/dummy/spec/helpers/react_on_rails_helper_spec.rb, line 79 [r2] (raw file):
💯

---

Comments from the review on Reviewable.io

[justin808]

Thanks @aaronvb and @tangrufus. I'll do a release in a little bit.

[aaronvb]

@justin808 @tangrufus Good work, glad we got this PR finished!