Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server Side rendering disabled if HMR running #1156

Merged
merged 2 commits into from
Oct 14, 2018
Merged

Server Side rendering disabled if HMR running #1156

merged 2 commits into from
Oct 14, 2018

Conversation

justin808
Copy link
Member

@justin808 justin808 commented Oct 14, 2018 •
edited
Loading

Reasonable to skip server rendering when HMR is turned on.

This change is Reviewable

@justin808
Server Side rendering disabled if HMR running
4665e66 
Reasonable to skip server rendering when HMR is turned on.
@coveralls
Copy link

Coverage Status

Coverage remained the same at ?% when pulling 4665e66 on justin808/disable-server-rendering-if-hmr into 28c6187 on master.

@coveralls
Copy link

coveralls commented Oct 14, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at ?% when pulling f70f765 on justin808/disable-server-rendering-if-hmr into 28c6187 on master.

@justin808 justin808 merged commit 782e5c7 into master Oct 14, 2018
@justin808 justin808 deleted the justin808/disable-server-rendering-if-hmr branch October 14, 2018 22:34
coopersamuel
coopersamuel reviewed Oct 14, 2018
View reviewed changes
Copy link
Contributor

@coopersamuel coopersamuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin808 so essentially this PR disables server rendering when developing with HMR

@jakeNiemiec jakeNiemiec mentioned this pull request Jan 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coopersamuel coopersamuel coopersamuel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justin808 @coveralls @coopersamuel