-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Arrays in Rails i18n yml files #1129
Ignore Arrays in Rails i18n yml files #1129
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comments
Reviewed 4 of 4 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @vcarel)
CHANGELOG.md, line 11 at r1 (raw file):
Changes since last non-beta release. - Ignore Arrays in Rails i18n yml files
see formatting of other entries
lib/react_on_rails/locales_to_js.rb, line 110 at r1 (raw file):
if v.is_a? Hash flatten(v).map { |hk, hv| h["#{k}.#{hk}".to_sym] = hv } elsif v.is_a? Array
elsif !v.is_a?(Array)
# Arrays are not supported by react-intl
h[k] = v.gsub("%{", "{")
@vcarel any update? |
@justin808 I'm on vacation for 2 weeks. I'll look into that when I'll be back in. Thx for your review. |
397cf44
to
d093f21
Compare
@justin808 I just did the update, sorry for the delay. |
@vcarel can you please rebase on top of master and ensure that CI passes. |
d093f21
to
1994c24
Compare
Thanks @vcarel! |
Fixes #1126
This change is