-
-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc updates, fix test helper #1093
Conversation
ce6ec06
to
87ff7e8
Compare
57e81c7
to
571dd45
Compare
Review status: all files reviewed at latest revision, all discussions resolved, some commit checks broke. lib/react_on_rails/prerender_error.rb, line 6 at r1 (raw file):
do we create an issue so we don't forget and maybe a newcomer could take this? lib/react_on_rails/version_syntax_converter.rb, line 5 at r1 (raw file):
👍 spec/react_on_rails/configuration_spec.rb, line 11 at r1 (raw file):
I'd put the spec/react_on_rails/utils_spec.rb, line 87 at r1 (raw file):
nice, wasn't aware of spec/react_on_rails/test_helper/webpack_assets_status_checker_spec.rb, line 60 at r1 (raw file):
not for this PR but for tests in the future I'd try to stay of using Is a cop in the rubocop-rspec: https://github.com/rubocop-hq/rubocop-rspec/blob/master/lib/rubocop/cop/rspec/let_setup.rb#L31 Comments from Reviewable |
This is the case that is fixed: Test helper for detecting stale bundles did not properly handle the case of a server-bundle.js without a hash. This is reproducible: git clone https://github.com/shakacode/react-webpack-rails-tutorial bundle && yarn rspec See that the server-bundle.js is reported as missing.
2b07cc1
to
a7f79de
Compare
Test helper for detecting stale bundles did not properly handle the case
of a server-bundle.js without a hash.
This is reproducible:
See that the server-bundle.js is reported as missing.
This change is