Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redux in generated hello world example #1006

Closed
wants to merge 2 commits into from
Closed

Use redux in generated hello world example #1006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
accfd38
Use redux in generated hello world example
lewaabahmad Jan 8, 2018
8f55608
Update CHANGELOG.md after PR
lewaabahmad Jan 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,6 @@ npm-debug.*
/gen-examples

.DS_Store
*.swp
*.swo

4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ Changes since last non-beta release.

*Please add entries here for your pull requests that are not yet released.*

### [10.0.3] - 2018-1-8
#### Fixed
- Use redux component in generated redux Hello World example: [PR 1006](https://github.com/shakacode/react_on_rails/pull/1006) by [lewaabahmad](https://github.com/lewaabahmad).

### [10.0.2] - 2017-11-10
#### Fixed
- Remove unnecessary dependencies from released NPM package: [PR 968](https://github.com/shakacode/react_on_rails/pull/968) by [tricknotes](https://github.com/tricknotes).
Expand Down
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/react_with_redux_generator.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ def create_redux_directories
end

def copy_base_files
base_js_path = "base/base"
base_js_path = "redux/base"
base_files = %w[app/javascript/bundles/HelloWorld/components/HelloWorld.jsx]
base_files.each { |file| copy_file("#{base_js_path}/#{file}", file) }
end
Expand Down