Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use redux in generated hello world example #1006

Closed
wants to merge 2 commits into from
Closed

Use redux in generated hello world example #1006

wants to merge 2 commits into from

Conversation

lewaabahmad
Copy link

@lewaabahmad lewaabahmad commented Jan 8, 2018

This change is Reviewable

@justin808
Copy link
Member

:lgtm:

Thanks!


Review status: 0 of 3 files reviewed at latest revision, 1 unresolved discussion.


.gitignore, line 36 at r1 (raw file):

.DS_Store
*.swp
*.swo

this probably doesn't need to be part of the of the .gitignore


Comments from Reviewable

@justin808
Copy link
Member

Let's remove the .gitignore change and I'll merge and publish a new version.


Reviewed 3 of 3 files at r1.
Review status: all files reviewed at latest revision, 1 unresolved discussion.


Comments from Reviewable

@justin808
Copy link
Member

@lewaabahmad please ping me when you remove the .gitignore changes. Or let me know why they are needed.

@justin808
Copy link
Member

@lewaabahmad Can you please let me know about the .gitignore change?

2 similar comments
@justin808
Copy link
Member

@lewaabahmad Can you please let me know about the .gitignore change?

@justin808
Copy link
Member

@lewaabahmad Can you please let me know about the .gitignore change?

@justin808
Copy link
Member

See PR #1019

@justin808 justin808 closed this Jan 24, 2018
@lewaabahmad
Copy link
Author

@justin808 Sorry!!! I really didn't see those notifications! Was just checking the issue and saw it was merged.

I added those because of Vim! Vim creates those files to make edits!

Again, my most sincere apologies! Glad this was good! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants