Support React-Hot-Loader v3

[justin808]

Looks like React on Rails should allow this:

https://github.com/gaearon/react-hot-loader/tree/master/docs#migration-to-30

When we call ReactDOM.render, we could automatically create the AppContainer if a preference for hot relading is set.

import React from 'react'
import ReactDOM from 'react-dom'
import { AppContainer } from 'react-hot-loader'
import App from './containers/App'

ReactDOM.render(
  <AppContainer>
    <App/>
  </AppContainer>,
  document.getElementById('root')
);

// Hot Module Replacement API
if (module.hot) {
  module.hot.accept('./containers/App', () => {
    const NextApp = require('./containers/App').default;
    ReactDOM.render(
      <AppContainer>
        <NextApp/>
      </AppContainer>,
      document.getElementById('root')
    );
  });
}

Anybody want to try this and submit a PR?

[justin808]

@Judahmeek does the new hot loader require any changes to React on Rails?

[Judahmeek]

No, it does not. React on Rails already supports hot reloading with RHL 3 (Example).

[justin808]

@Judahmeek This looks more like a doc than a code issue.

[justin808]

We need to update https://github.com/shakacode/react_on_rails/blob/master/docs/additional-reading/hot-reloading-rails-development.md with what was done on #865

Any volunteers?

[LyzioOh]

I go for it :-), i want easy hot module replacement on my project.

[justin808]

@EEtancelin I've changed the tag on this one to mark it as owned by you. Please get back to me soon to let me know of the progress and any questions. Definitely reach out to @Judahmeek with any questions as well, maybe in our Slack room for ShakaCode.

[justin808]

Supporting hot loader changes is out of scope for React on Rails currently.