Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect relative symlink generated for assets in subfolders #546

Closed
varyonic opened this issue Sep 9, 2016 · 5 comments
Closed

Incorrect relative symlink generated for assets in subfolders #546

varyonic opened this issue Sep 9, 2016 · 5 comments
Labels

Comments

@varyonic
Copy link

varyonic commented Sep 9, 2016

e.g. as of 6.0.3 after #446 in public/assets/flags I have note.png -> flags/note-80ea..6a.png

@justin808
Copy link
Member

@varyonic please try 6.1.1 and let me know ASAP if that fixes the issue.

@justin808
Copy link
Member

@varyonic Any info on if I can close this issue?

@varyonic
Copy link
Author

Tried 6.1.1 and behavior appeared unchanged to me.

@justin808
Copy link
Member

@varyonic I see. You're concerned that we're creating assets with that point back to the non-fingerprinted ones. We considered handling this case. However, it seems that this should cause no harm.

What is the issue that you have with this?

I can show you what needs to change if this bothers you and you'd like to submit a PR. It's pretty easy to make this change. We just didn't see the value in doing the extra coding.

@varyonic
Copy link
Author

OK, fixed an issue with our build process not being clean and 6.1.1 looks good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants