Replacing URI.parse with Addressable

[lucke84]

It seems the new rails_context method uses uri = URI.parse(request.original_url), which sometimes fails to parse URIs with non-ASCII characters (see react_on_rails_helper.rb, line 361)

Here's an example of a real-life(-ish) URI that should be supported but fails on our ReactOnRails powered website:

http://mywebsite.com/mypage?myparam=méridien

(note the é character in myparam's value), returning an error like:

URI::InvalidURIError: URI must be ascii only "http://mywebsite.com/mypage?myparam=mm\u{e9}ridien"

The addressable gem seems to be a valid alternative (which might become the official replacement for URI in the future). Unless I'm missing something here, is there a possibility to switch to using addressable?

Feedback of what I might be doing wrong (e.g. not encoding properly?) are more than welcome as well.

[jbhatab]

@lucke84 interesting. Would you mind making a PR for this?

[lucke84]

See #405 :)

[jbhatab]

@lucke84 looks good. just check out Justins comments, I agree with both of them. Besides that, awesome work.

[lucke84]

Happy to help :) The comment have been fixed already, it'd be nice to .

[justin808]

Merged.