Skip to content

Commit

Permalink
Merge pull request #514 from AlexKVal/misc-fixes
Browse files Browse the repository at this point in the history
Misc fixes (unimportant)
  • Loading branch information
justin808 authored Aug 12, 2016
2 parents c49f5d2 + 92f7a8c commit a6373f0
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 9 deletions.
2 changes: 1 addition & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ node_modules
/node_package/lib

npm-debug.*
spec/dummy/client/npm-debug.log.*
spec/dummy/client/npm-debug.log*

/gen-examples

Expand Down
2 changes: 1 addition & 1 deletion lib/generators/USAGE
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ Then you may run

More Details:

`https://github.com/shakacode/react_on_rails#generator`
`https://github.com/shakacode/react_on_rails/blob/master/docs/basics/generator.md`
2 changes: 1 addition & 1 deletion lib/generators/react_on_rails/base_generator.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def add_hello_world_route
def update_git_ignore
data = <<-DATA.strip_heredoc
# React on Rails
npm-debug.log
npm-debug.log*
node_modules
# Generated js bundles
Expand Down
7 changes: 4 additions & 3 deletions spec/dummy/client/webpack.client.base.config.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Common client-side webpack configuration used by webpack.hot.config and webpack.rails.config.
// Common client-side webpack configuration used by
// webpack.client.rails.hot.config and webpack.client.rails.build.config.

const webpack = require('webpack');
const path = require('path');
Expand All @@ -22,9 +23,9 @@ module.exports = {
'jquery',
],

// This will contain the app entry points defined by webpack.hot.config and webpack.rails.config
// This will contain the app entry points defined by
// webpack.client.rails.hot.config and webpack.client.rails.build.config
app: [
// './app/assets/styles/global-styles.scss',
'./app/startup/clientRegistration',
],
},
Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/client/webpack.client.rails.build.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ config.output = {
path: '../app/assets/webpack',
};

// See webpack.common.config for adding modules common to both the webpack dev server and rails
// See webpack.client.base.config for adding modules common to both the webpack dev server and rails

config.module.loaders.push(
{
Expand Down
2 changes: 1 addition & 1 deletion spec/react_on_rails/generators/install_generator_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
.gitignore was not found.
Please add the following content to your .gitignore file:
# React on Rails
npm-debug.log
npm-debug.log*
node_modules
# Generated js bundles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
match = <<-MATCH.strip_heredoc
some existing text
# React on Rails
npm-debug.log
npm-debug.log*
node_modules
# Generated js bundles
Expand Down

0 comments on commit a6373f0

Please sign in to comment.