Skip to content

Commit 73f32e1

Browse files
committed
Changed default for raise_on_prerender_error
Now set to raise during development. config.raise_on_prerender_error = Rails.env.development?
1 parent d9dc568 commit 73f32e1

File tree

3 files changed

+13
-6
lines changed

3 files changed

+13
-6
lines changed

CHANGELOG.md

+9
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,15 @@ Changes since last non-beta release.
2222

2323
- Enabled the use of webpack-dev-server with Server-side rendering. (https://github.com/shakacode/react_on_rails/pull/1173) by [justin808](https://github.com/justin808) and [judahmeek](https://github.com/judahmeek).
2424

25+
#### Changed
26+
- Changed the default for:
27+
```rb
28+
config.raise_on_prerender_error = Rails.env.development?
29+
```
30+
31+
Thus, developers will need to fix server rendering errors before continuing.
32+
[PR 1145](https://github.com/shakacode/react_on_rails/pull/1145) by [justin808](https://github.com/justin808).
33+
2534
### [11.1.8] - 2018-10-14
2635

2736
#### Improved

docs/basics/configuration.md

+3-2
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,9 @@ ReactOnRails.configure do |config|
144144
#
145145
config.logging_on_server = true
146146

147-
# Default is to false to NOT raise exception on server if the JS code throws.
148-
# Reason is that it's easier to debug this when you get the error over to the client.
147+
# Default is true only for development? to raise exception on server if the JS code throws for
148+
# server rendering. The reason is that the server logs will show the error and force you to fix
149+
# any server rendering issues immediately during development.
149150
#
150151
config.raise_on_prerender_error = Rails.env.development?
151152

lib/react_on_rails/configuration.rb

+1-4
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,7 @@ def self.configuration
2121
prerender: false,
2222
replay_console: true,
2323
logging_on_server: true,
24-
raise_on_prerender_error: false,
25-
# Should we change?
26-
# raise_on_prerender_error: Rails.env.development?,
27-
24+
raise_on_prerender_error: Rails.env.development?,
2825
trace: Rails.env.development?,
2926
development_mode: Rails.env.development?,
3027
server_renderer_pool_size: DEFAULT_POOL_SIZE,

0 commit comments

Comments
 (0)