Make the tests pass

Author: jtibbertsma

node_package/src/ComponentRegistry.js

@@ -1,5 +1,5 @@
 // key = name used by react_on_rails
-// value = { name, component, generatorFunction: boolean }
+// value = { name, component, generatorFunction: boolean, isRenderer: boolean }
 import generatorFunction from './generatorFunction';
 
 const registeredComponents = new Map();
@@ -20,38 +20,13 @@ export default {
       }
 
       const isGeneratorFunction = generatorFunction(component);
+      const isRenderer = isGeneratorFunction && component.length === 3;
 
       registeredComponents.set(name, {
         name,
         component,
         generatorFunction: isGeneratorFunction,
-        isRenderer: false,
-      });
-    });
-  },
-
-  /**
-   * @param renderers { renderer1: renderer1, renderer2: renderer2, etc. }
-   */
-  registerRenderer(renderers) {
-    Object.keys(renderers).forEach(name => {
-      if (registeredComponents.has(name)) {
-        console.warn('Called registerRenderer for component that is already registered', name);
-      }
-
-      const renderer = renderers[name];
-
-      // A renderer must be a function
-      if (!generatorFunction(renderer)) {
-        throw new Error(`Called registerRenderer without passing a function; component name \
-is ${name}`);
-      }
-
-      registeredComponents.set(name, {
-        name,
-        component: renderer,
-        generatorFunction: false,
-        isRenderer: true,
+        isRenderer,
       });
     });
   },

node_package/src/ReactOnRails.js

@@ -41,17 +41,6 @@ ctx.ReactOnRails = {
     StoreRegistry.register(stores);
   },
 
-  /**
-   * Allows registration of renderers. A renderer is a function that accept three args:
-   * props, railsContext, and domNodeId, and is responsible for rendering a component
-   * to the DOM. Not available on the server. For one possible use case see:
-https://github.com/shakacode/react_on_rails/blob/master/docs/additional-reading/code-splitting.md
-   * @param renderers (key is component name, value is renderer)
-   */
-  registerRenderer(renderers) {
-    ComponentRegistry.registerRenderer(renderers);
-  },
-
   /**
    * Allows retrieval of the store by name. This store will be hydrated by any Rails form props.
    * Pass optional param throwIfMissing = false if you want to use this call to get back null if the

node_package/tests/serverRenderReactComponent.test.js

@@ -46,7 +46,7 @@ test('serverRenderReactComponent renders an error if attempting to render a rend
   const { html } =
     JSON.parse(serverRenderReactComponent({ name: 'X3', domNodeId: 'myDomId', trace: false }));
 
-  const ok = html.indexOf('registerRenderer') > 0 && html.indexOf('Exception in rendering!') > 0;
+  const ok = html.indexOf('renderer') > 0 && html.indexOf('Exception in rendering!') > 0;
   assert.ok(
     ok,
     'serverRenderReactComponent renders an error if attempting to render a renderer',